-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat: Support defining tags per subnet name #1139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: Support defining tags per subnet name #1139
Conversation
Doh, that'll teach me to not check open PR's first... #1131 does essentially the same thing... |
This PR has been automatically marked as stale because it has been open 30 days |
Refreshed branch from master 👍 |
Any update on this? It would be quite useful! |
This PR has been automatically marked as stale because it has been open 30 days |
5c8c99e
to
bc75244
Compare
Still would be good to get this merged. I've just rebased from |
bc75244
to
00252ec
Compare
This would be a useful feature if you have many subnets of one type and need to distinguish them by tag. |
This PR has been automatically marked as stale because it has been open 30 days |
This commit updates the module to support defining subnet tags per subnet name, in addition to per AZ. Reasoning behind this is to allow for specific tags to be applied to different public/private subnets. E.g. ```terraform private_subnet_names = ["Private Subnet One", "Private Subnet Two"] private_subnet_tags_per_name = { "Private Subnet One" = { "subnet one" = "true" }, "Private Subnet Two" = { "subnet two" = "true" } } ```
Needed to upgraded to latest `0.19.0` version locally...
00252ec
to
aa2c810
Compare
Description
This commit updates the module to support defining subnet tags per subnet name, in addition to per AZ.
Motivation and context
Reasoning behind this is to allow for specific tags to be applied to different public/private subnets.
E.g.
Fixes #1129